Skip to content

[tool] Adjust error message when downgrade fails#10734

Merged
auto-submit[bot] merged 2 commits intoflutter:mainfrom
stuartmorgan-g:tool-analyze-downgrade-message
Jan 29, 2026
Merged

[tool] Adjust error message when downgrade fails#10734
auto-submit[bot] merged 2 commits intoflutter:mainfrom
stuartmorgan-g:tool-analyze-downgrade-message

Conversation

@stuartmorgan-g
Copy link
Collaborator

Since pub downgrade runs package resolution, failure in that step can simply mean that resolution has failed, rather than indicating a problem with the actual downgrade process. This adjusts the message to make it clear that it's a potential resolver failure, to aid in understanding failures.

Fixes flutter/flutter#178815

Since `pub downgrade` runs package resolution, failure in that step can
simply mean that resolution has failed, rather than indicating a problem
with the actual downgrade process. This adjusts the message to make it
clear that it's a potential resolver failure, to aid in understanding
failures.

Fixes flutter/flutter#178815
@stuartmorgan-g stuartmorgan-g marked this pull request as ready for review January 6, 2026 21:36
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adjusts the error message for a failed pub downgrade command within the analyze tool. The message is changed from "Unable to downgrade dependencies" to "Unable to resolve downgraded dependencies" to clarify that the failure is likely due to package resolution issues. A corresponding test that checks for this error message has also been updated.

Copy link
Contributor

@bparrishMines bparrishMines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2026
@auto-submit
Copy link
Contributor

auto-submit bot commented Jan 27, 2026

autosubmit label was removed for flutter/packages/10734, because - The status or check suite Mac_arm64 ios_platform_tests_shard_3 master has failed. Please fix the issues identified (or deflake) before re-applying this label.

@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Jan 27, 2026
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Jan 29, 2026
@auto-submit auto-submit bot merged commit ed3ff4c into flutter:main Jan 29, 2026
81 checks passed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jan 30, 2026
github-merge-queue bot pushed a commit to flutter/flutter that referenced this pull request Jan 30, 2026
flutter/packages@cd4fd61...510dd40

2026-01-30 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
bd7a4a6 to 67323de (3 revisions) (flutter/packages#10924)
2026-01-29 engine-flutter-autoroll@skia.org Roll Flutter from
dfd92b7 to da72d59 (39 revisions) (flutter/packages#10923)
2026-01-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Retrieve lens direction from CameraX directly
(flutter/packages#10847)
2026-01-29 stuartmorgan@google.com [tool] Adjust error message when
`downgrade` fails (flutter/packages#10734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
LongCatIsLooong pushed a commit to LongCatIsLooong/flutter that referenced this pull request Feb 6, 2026
…r#181726)

flutter/packages@cd4fd61...510dd40

2026-01-30 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
bd7a4a6 to 67323de (3 revisions) (flutter/packages#10924)
2026-01-29 engine-flutter-autoroll@skia.org Roll Flutter from
dfd92b7 to da72d59 (39 revisions) (flutter/packages#10923)
2026-01-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Retrieve lens direction from CameraX directly
(flutter/packages#10847)
2026-01-29 stuartmorgan@google.com [tool] Adjust error message when
`downgrade` fails (flutter/packages#10734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
flutter-zl pushed a commit to flutter-zl/flutter that referenced this pull request Feb 10, 2026
…r#181726)

flutter/packages@cd4fd61...510dd40

2026-01-30 engine-flutter-autoroll@skia.org Roll Flutter (stable) from
bd7a4a6 to 67323de (3 revisions) (flutter/packages#10924)
2026-01-29 engine-flutter-autoroll@skia.org Roll Flutter from
dfd92b7 to da72d59 (39 revisions) (flutter/packages#10923)
2026-01-29 43054281+camsim99@users.noreply.github.com
[camera_android_camerax] Retrieve lens direction from CameraX directly
(flutter/packages#10847)
2026-01-29 stuartmorgan@google.com [tool] Adjust error message when
`downgrade` fails (flutter/packages#10734)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages-flutter-autoroll
Please CC flutter-ecosystem@google.com on the revert to ensure that a
human
is aware of the problem.

To file a bug in Flutter:
https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[packages] Improve downgraded analyze error message

2 participants